Skip to content

Commit

Permalink
Avoid unnecessary M.VisualBasic and S.ValueTuple dependencies
Browse files Browse the repository at this point in the history
Found in dotnet/runtime#96795 (comment)

These packages shouldn't be referenced on modern TFMs as the types are already provided inbox by the framework.
  • Loading branch information
ViktorHofer authored Jan 24, 2024
1 parent 64a8afa commit 0138c8b
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="1.0.1" />
<PackageReference Include="Microsoft.VisualBasic" Version="10.0.1" />
<PackageReference Include="Microsoft.VisualBasic" Version="10.0.1" Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'" />
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="16.1.8" />
<PackageReference Include="Nullable" Version="1.3.0" PrivateAssets="all" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" Condition="'$(TargetFramework)' == 'netstandard1.6' or '$(TargetFramework)' == 'net452' or '$(TargetFramework)' == 'net46'" />

<!-- Use PrivateAssets=compile to avoid exposing our NuGet dependencies downstream as public API. -->
<PackageReference Include="NuGet.Common" Version="$(NuGetApiVersion)" PrivateAssets="compile" />
Expand Down

0 comments on commit 0138c8b

Please sign in to comment.