Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook setup #7

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Storybook setup #7

merged 2 commits into from
Feb 23, 2021

Conversation

zthh626
Copy link
Contributor

@zthh626 zthh626 commented Feb 23, 2021

Added Storybook.
Stories for content, header, and sidebar.
Updated README with npm downgrade note because of this issue: storybookjs/storybook#12983
Added Storybook design addon:
Screen Shot 2021-02-22 at 8 36 23 PM

Added Storybook and design add on. Added stories to content, header, and sidebar with proptypes.
@zthh626 zthh626 requested review from a team and keithradford February 23, 2021 04:47
@zthh626 zthh626 self-assigned this Feb 23, 2021
@aomi
Copy link
Member

aomi commented Feb 23, 2021

@zthh626 Can we add a note about the potential issues using v7 of npm and maybe a note about starting this in the local environment in the README?

@zthh626
Copy link
Contributor Author

zthh626 commented Feb 23, 2021

@aomi I left this in the README, is this enough, or should I add more context?

@aomi
Copy link
Member

aomi commented Feb 23, 2021

@aomi I left this in the README, is this enough, or should I add more context?

I think we could add a link to the issue that tracks it in the PR and in the README. Also mentioning how to run it (I saw it in package.json but for the sake of people unfamiliar with Storybook or even doesn't know it exists would be good. A link to Storybook might be good too.

@zthh626 zthh626 requested a review from aomi February 23, 2021 05:21
@zthh626 zthh626 merged commit 7cb4292 into main Feb 23, 2021
@zthh626 zthh626 deleted the storybook-setup branch February 23, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants