Fix property value undefined check (opensearch-project#276)

If property value is false, property is not added. Replace check with undefined to accept false value. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB · Feb 22, 2023 · f88aa15 · f88aa15
1 parent c3ebf3a
commit f88aa15
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/public/model/documentLayerFunctions.ts b/public/model/documentLayerFunctions.ts
@@ -34,18 +34,14 @@ const openSearchGeoJSONMap = new Map<string, string>([
 
 const getFieldValue = (data: any, name: string) => {
   if (!name) {
-    return null;
+    return undefined;
   }
   const keys = name.split('.');
   return keys.reduce((pre, cur) => {
     return pre?.[cur];
   }, data);
 };
 
-const getCurrentStyleLayers = (maplibreRef: MaplibreRef) => {
-  return maplibreRef.current?.getStyle().layers || [];
-};
-
 const getGeoFieldType = (layerConfig: DocumentLayerSpecification) => {
   return layerConfig?.source?.geoFieldType;
 };
@@ -84,8 +80,8 @@ const buildProperties = (document: any, fields: string[]) => {
     return property;
   }
   fields.forEach((field) => {
-    const fieldValue = getFieldValue(document._source, field);
-    if (fieldValue) {
+    const fieldValue: string | undefined = getFieldValue(document._source, field);
+    if (fieldValue !== undefined) {
       property[field] = fieldValue;
     }
   });