Code

Render collections#274

Code

Merged

joelhawksley merged 36 commits intomasterViewComponent/view_component:masterfrom render-collectionsViewComponent/view_component:render-collectionsCopy head branch name to clipboardMar 27, 2020

+205-9

Commits

Commits on Mar 24, 2020

• Sketch out API for rendering collections

  Show description for e1f0bce
  

  tclem

  and

  joelhawksley

  committed
  e1f0bce

  Copy full SHA for e1f0bce

• Final newlines are nice

  tclem

  committed
  c8997b1

  Copy full SHA for c8997b1

• Rename template

  tclem

  committed
  698fa7d

  Copy full SHA for 698fa7d

• Handle :as, fill out test coverage

  tclem

  committed
  0fe965f

  Copy full SHA for 0fe965f

• Test out not using :as

  tclem

  committed
  7aaef37

  Copy full SHA for 7aaef37

• Merge remote-tracking branch 'origin/master' into render-collections

  tclem

  committed
  d6f435e

  Copy full SHA for d6f435e

• Name the ivar item for clarity

  tclem

  committed
  6df4749

  Copy full SHA for 6df4749

Commits on Mar 25, 2020

• Change up the api to .all(collection: ...)

  tclem

  committed
  6750a3a

  Copy full SHA for 6750a3a

• Move default kw to as_variable

  tclem

  committed
  6d96256

  Copy full SHA for 6d96256

• Auto generate item name

  tclem

  committed
  6a3e54c

  Copy full SHA for 6a3e54c

• Handle passing collection object directly

  tclem

  committed
  492c711

  Copy full SHA for 492c711

• Duplicative of ProductCoupon

  tclem

  committed
  85806b4

  Copy full SHA for 85806b4

• Just change the listing order

  tclem

  committed
  a41527b

  Copy full SHA for a41527b

• Move ViewComponent:Collection to a dedicated file

  tclem

  committed
  4b7e367

  Copy full SHA for 4b7e367

• Draft a changelog entry

  tclem

  committed
  c872eae

  Copy full SHA for c872eae

• Add myself to the readme and tidy contributors

  tclem

  committed
  2255967

  Copy full SHA for 2255967

• Add space after comma

  tclem

  committed
  606d568

  Copy full SHA for 606d568

Commits on Mar 26, 2020

• Use the component class name directly

  tclem

  committed
  9baecd1

  Copy full SHA for 9baecd1

• More specific asserts for extra arguments

  tclem

  committed
  556de9e

  Copy full SHA for 556de9e

• ViewComponent::Collection constructor can be private

  tclem

  committed
  f897365

  Copy full SHA for f897365

• Be defensive against component changing the args hash

  tclem

  committed
  3793dd3

  Copy full SHA for 3793dd3

• s/all/with_collection

  tclem

  committed
  f294f99

  Copy full SHA for f294f99

• Iterate on the api

  Show description for 44f326d
  tclem

  committed
  44f326d

  Copy full SHA for 44f326d

• Bring tests up-to-date

  tclem

  committed
  9f1bc8a

  Copy full SHA for 9f1bc8a

• Express these as list items

  tclem

  committed
  84a6495

  Copy full SHA for 84a6495

• Wire up an integration test

  tclem

  committed
  6c3e7ee

  Copy full SHA for 6c3e7ee

• html_safe is required for rendered content to show up

  tclem

  committed
  7196bef

  Copy full SHA for 7196bef

• Different versions of ruby show slightly different errors here

  tclem

  committed
  1b186fe

  Copy full SHA for 1b186fe

• Update api in changelog entry

  tclem

  committed
  340122b

  Copy full SHA for 340122b

• Bump version to 2.1.0

  tclem

  committed
  4364c69

  Copy full SHA for 4364c69

• No need to use ivars in these tests

  tclem

  committed
  6612f8b

  Copy full SHA for 6612f8b

• Update test/view_component/view_component_test.rb

  Show description for 5a13abe
  

  tclem

  and

  joelhawksley

  authored
  5a13abe

  Copy full SHA for 5a13abe

• Revert "Bump version to 2.1.0"

  Show description for a1b85fc
  tclem

  committed
  a1b85fc

  Copy full SHA for a1b85fc

• Add some documentation to the readme

  tclem

  committed
  93b3cdc

  Copy full SHA for 93b3cdc

Commits on Mar 27, 2020

• Didn't mean to replace these

  tclem

  committed
  b09ca46

  Copy full SHA for b09ca46

• Update CHANGELOG.md

  joelhawksley

  authored
  c32d066

  Copy full SHA for c32d066