Skip to content

Commit

Permalink
Test against turbo-rails v2
Browse files Browse the repository at this point in the history
hotwired/turbo-rails#294 was closed, which prompted me to check that the issue had been fixed. It's been closed as stale, but this puts us on the latest `turbo-rails` for testing this incompatibility.

Since we're no longer testing against a version of Rails that's incompatible with `turbo-rails`, I've made it a development dependency.
  • Loading branch information
boardfish committed Sep 16, 2024
1 parent ec0434c commit 4a82b61
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 29 deletions.
4 changes: 0 additions & 4 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,16 @@ appraise "rails-6.1" do
gem "net-smtp", require: false
gem "net-imap", require: false
gem "net-pop", require: false
gem "turbo-rails", "~> 1"
end

appraise "rails-7.0" do
gem "rails", "~> 7.0"
gem "tailwindcss-rails", "~> 2.0"
gem "turbo-rails", "~> 1"
end

appraise "rails-7.1" do
gem "rails", "~> 7.1"
gem "tailwindcss-rails", "~> 2.0"
gem "turbo-rails", "~> 1"
end

appraise "rails-7.2" do
Expand All @@ -31,5 +28,4 @@ end
appraise "rails-main" do
gem "rails", github: "rails/rails", branch: "main"
gem "tailwindcss-rails", "~> 2.0"
gem "turbo-rails", "~> 1"
end
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ GEM
thor (1.3.2)
tilt (2.4.0)
timeout (0.4.1)
turbo-rails (1.5.0)
turbo-rails (2.0.7)
actionpack (>= 6.0.0)
activejob (>= 6.0.0)
railties (>= 6.0.0)
Expand Down Expand Up @@ -357,7 +357,7 @@ DEPENDENCIES
slim (~> 5.1)
sprockets-rails (~> 3.4.2)
standard (~> 1)
turbo-rails (~> 1)
turbo-rails (~> 2)
view_component!
warning
yard (~> 0.9.34)
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails_6.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ gem "tailwindcss-rails", "~> 2.0"
gem "net-smtp", require: false
gem "net-imap", require: false
gem "net-pop", require: false
gem "turbo-rails", "~> 1"

gemspec path: "../"
1 change: 0 additions & 1 deletion gemfiles/rails_7.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ source "https://rubygems.org"

gem "rails", "~> 7.0"
gem "tailwindcss-rails", "~> 2.0"
gem "turbo-rails", "~> 1"

gemspec path: "../"
1 change: 0 additions & 1 deletion gemfiles/rails_7.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ source "https://rubygems.org"

gem "rails", "~> 7.1"
gem "tailwindcss-rails", "~> 2.0"
gem "turbo-rails", "~> 1"

gemspec path: "../"
20 changes: 2 additions & 18 deletions gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,9 @@

source "https://rubygems.org"

gem "capybara", "~> 3"
gem "rails", "~> 7.2"
gem "rspec-rails", "~> 5"
gem "net-imap", require: false
gem "net-pop", require: false
gem "net-smtp", require: false
gem "debug"
ruby "~> 3.3"

gem "rails", "~> 7.2"
gem "tailwindcss-rails", "~> 2.0"

group :test do
gem "cuprite", "~> 0.15"
gem "puma", "~> 6"
gem "warning"
gem "selenium-webdriver", "4.9.0"
end

group :development, :test do
gem "appraisal", "~> 2.5"
end

gemspec path: "../"
1 change: 0 additions & 1 deletion gemfiles/rails_main.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ source "https://rubygems.org"

gem "rails", github: "rails/rails", branch: "main"
gem "tailwindcss-rails", "~> 2.0"
gem "turbo-rails", "~> 1"

gemspec path: "../"
2 changes: 2 additions & 0 deletions test/sandbox/config/cable.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
test:
adapter: test
2 changes: 1 addition & 1 deletion view_component.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "simplecov-console", "~> 0.9.1"
spec.add_development_dependency "slim", "~> 5.1"
spec.add_development_dependency "sprockets-rails", "~> 3.4.2"
spec.add_development_dependency "turbo-rails", "~> 1"
spec.add_development_dependency "turbo-rails", "~> 2"
spec.add_development_dependency "warning"
spec.add_development_dependency "yard", "~> 0.9.34"
spec.add_development_dependency "yard-activesupport-concern", "~> 0.0.1"
Expand Down

0 comments on commit 4a82b61

Please sign in to comment.