Improvements to folders tree (v2) #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't proceed to folder move if Database's -setParent:forFolder: or -setNextSibling:folderFromID:forFolder: return NO. Adapt accordingly the insertion into undoArray.
Remove extraneous spaces while keeping the tab based spacing in order to preserve the legibility of git history. Other slight changes to improve legibility.
I experienced that the recovery procedure led to an incoherent tree, so the best workaround remains switching back to alphabetical auto sort by reverting commit e3751a9. However, reselect user's choice after that. As mail exchanges with user @liamgreenwood around issue ViennaRSS#1768 hinted that "loss" of a sibling is the likely origin of -loadTree:rootNode's failure, try to find it and reattach it as soon as it is reported missing.
barijaona
force-pushed
the
foldersTree
branch
2 times, most recently
from
5412d2e to
a4c8c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1783, should help with issues #1768, #1779 and #1784.
I decided to revert PR #1754 (Improve handling of FoldersTree manual sort issues) and implement a better handling of siblings reported as missing in
-loadTree:rootNode:As in #1783, check
-setParent:forFolder:and-setNextSibling:folderFromID:forFolder:success or failure before moving a tree node.