-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat / a11y improve the contrast of non-texts #55
Conversation
a92aafa
to
1968b45
Compare
@@ -37,7 +37,7 @@ | |||
|
|||
.info { | |||
position: relative; | |||
width: 70%; | |||
width: 50%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove @include responsive.tablet-only() { width: 350px; }
couple of lines further. Because it makes the text description really narrow.
So you agree @royschut ? If so, can you make perform this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't that break the purpose again, making text appear above the image? @langemike
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should actually show less of the image and more of the text. But that's a design (UI) choice.
a240e19
to
fb7337f
Compare
This PR
OTT-416
text-shadows
,lineair-gradient
and decreasing themax-width
of theinfo
containerBefore both these changes:
![Screenshot 2024-01-25 at 20 08 00](https://private-user-images.githubusercontent.com/48496458/299783528-03f6a153-32c2-43f4-9959-61ea3e28c183.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjc5MjEsIm5iZiI6MTczOTUyNzYyMSwicGF0aCI6Ii80ODQ5NjQ1OC8yOTk3ODM1MjgtMDNmNmExNTMtMzJjMi00M2Y0LTk5NTktNjFlYTNlMjhjMTgzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDEwMDcwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYyZTQ1NmNkZmQ0ODc4NWRkYmU2N2NkYmU2YTk1ZTIzYzkxYWY5YjljZjViNWVmZTNjNGZkNDZhNGI4MDMyN2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9JD4T9MEbSpkvbJP6x5-SzroOtY7P3YykQxQdyXxyn4)
After the changes:
![Screenshot 2024-01-25 at 20 08 06](https://private-user-images.githubusercontent.com/48496458/299783575-575501b9-c047-47d6-8743-a8a283318658.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjc5MjEsIm5iZiI6MTczOTUyNzYyMSwicGF0aCI6Ii80ODQ5NjQ1OC8yOTk3ODM1NzUtNTc1NTAxYjktYzA0Ny00N2Q2LTg3NDMtYThhMjgzMzE4NjU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDEwMDcwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlkNWFlOTAwYTE3ZWYxMDVmNGI4MDY1MzY0YjVmMDUxZjVjYjI3OWIzZTU4NzE1ODczYWNjZTM5NmI3MDU4ZDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mxpwPyGdiwKOR6HtujJ3SuCdU_ohiMxS9dfqfMMrxbk)