Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat / a11y improve the contrast of non-texts #55

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

MelissaDTH
Copy link

@MelissaDTH MelissaDTH commented Jan 25, 2024

This PR

OTT-416

  • Enhances the readability of the description of media items and the featured card title
    • We do this by updating the text-shadows, lineair-gradient and decreasing the max-width of the info container
  • Adds a solid background color to the header component if this is not set via the JW config
    • I think that this change can be pretty opinionated, it has been discussed together with Stephan. This way we can ensure accessibility for now, but if we do not prefer this solution, we should discuss this a bit further.

Before both these changes:
Screenshot 2024-01-25 at 20 08 00

After the changes:
Screenshot 2024-01-25 at 20 08 06

@@ -37,7 +37,7 @@

.info {
position: relative;
width: 70%;
width: 50%;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove @include responsive.tablet-only() { width: 350px; } couple of lines further. Because it makes the text description really narrow.

Screenshot 2024-01-29 at 12 51 06

So you agree @royschut ? If so, can you make perform this change.

Copy link

@royschut royschut Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that break the purpose again, making text appear above the image? @langemike

Copy link

@langemike langemike Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true. I think due to the length of the text it gives a really unproportionate feeling. But with a small text it feels more balanced. I have to agree with you. Example with small text:
Screenshot 2024-01-30 at 09 31 33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should actually show less of the image and more of the text. But that's a design (UI) choice.

@ChristiaanScheermeijer ChristiaanScheermeijer force-pushed the feat/a11y-non-texts-contrast branch from a240e19 to fb7337f Compare January 29, 2024 12:21
@royschut royschut self-assigned this Jan 29, 2024
@langemike langemike merged commit bead070 into feat/a11y-sprint-2 Jan 30, 2024
5 of 8 checks passed
@langemike langemike deleted the feat/a11y-non-texts-contrast branch January 30, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants