New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick cleanup of the plugin mostly with formatting and spelling #455

Merged

FlorianMichael merged 2 commits into ViaVersion:dev from Diamondman121314:dev

Sep 21, 2023

Contributor

Diamondman121314 commented Sep 19, 2023 •

edited

Loading

I decided to go through the plugin before its 3.0.0 release which I assume to be somewhat soon and fix some things.

A list of what I've done:

Made the formatting of the plugin more consistent
Fixed some spelling errors of both fields and comments
Updated the dependencies to align with the other Via plugins
Changed some create methods to use the PacketType instead of the packet ID. I actually did this one way before I was told that it was going to be rewritten but I figured there was most likely not harm in keeping the changes

Diamondman121314 added 2 commits

September 18, 2023 21:51


          Make overall formatting more consistent plus a few spelling fixes and…

4298ed4

… minor changes


          Merge branch 'ViaVersion:dev' into dev

9624ec8

Member

FlorianMichael commented Sep 21, 2023

Thanks

FlorianMichael merged commit 3892a02 into ViaVersion:dev

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet