Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle 8.4, G1GC, Update dependencies. #275

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Gradle 8.4, G1GC, Update dependencies. #275

merged 1 commit into from
Oct 20, 2023

Conversation

Kichura
Copy link
Member

@Kichura Kichura commented Oct 20, 2023

  1. Adds G1GC to make compiling morely comfortable for VFP,
  2. Mixin Extras 0.2.0 has been finalized,
  3. Updates Gradle to 8.4,
  4. Updates Fabric Loader to 0.14.23,
  5. Updates Netty Codec to 4.1.100,
  6. Updates reflect to 1.3.0.

@FlorianMichael FlorianMichael merged commit 0acae91 into ViaVersion:main Oct 20, 2023
1 check passed
RaphiMC
RaphiMC requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@RaphiMC RaphiMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netty shouldn't be updated since that will cause dependency issues with the netty in minecraft. It should be the same version as minecraft uses for maximum compatiblity

@Kichura
Copy link
Member Author

Kichura commented Oct 20, 2023

Netty shouldn't be updated since that will cause dependency issues with the netty in minecraft. It should be the same version as minecraft uses for maximum compatiblity

Can be reverted then cuz i had just removed my fork. (i do this everytime on post-merge)

@FlorianMichael
Copy link
Member

Yeah, I reverted it, didn't saw that. @Kichura Please don't touch these libraries, I always sync them with ViaBedrock's version to prevent version mismatches/conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphiMC RaphiMC RaphiMC requested changes

@FlorianMichael FlorianMichael FlorianMichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kichura @FlorianMichael @RaphiMC