Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors #129

Merged
merged 1 commit into from
Feb 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ chrono = { git = "https://github.com/vectordotdev/chrono.git", branch = "no-defa
aws-config = { path = "patch/aws-config" }
aws-sigv4 = { path = "patch/aws-sigv4" }
hyper-openssl = { path = "patch/hyper-openssl" }
openssl = { path = "patch/openssl" }

[features]
ocp-logging = [
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile.unit
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
FROM registry.redhat.io/ubi8:6-754 as builder
FROM registry.redhat.io/ubi8:8.6-754 as builder

RUN INSTALL_PKGS=" \
cmake \
libarchive \
gcc-c++ \
make \
git \
openssl-devel \
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::dh::Dh;
use crate::error::ErrorStack;
use crate::ssl::{
HandshakeError, Ssl, SslContext, SslContextBuilder, SslContextRef, SslMethod, SslMode,
SslOptions, SslRef, SslStream, SslVerifyMode,
SslOptions, SslRef, SslStream, SslVerifyMode, SslVersion,
};
use crate::version;

Expand Down Expand Up @@ -217,6 +217,28 @@ impl DerefMut for ConnectConfiguration {
pub struct SslAcceptor(SslContext);

impl SslAcceptor {
pub fn custom(method: SslMethod, min_tls_version: &String, ciphersuites: &String) -> Result<SslAcceptorBuilder, ErrorStack> {
let mut ctx = ctx(method)?;
let min_proto_version: SslVersion;
match min_tls_version.as_str() {
"VersionTLS10" => min_proto_version = SslVersion::TLS1,
"VersionTLS11" => min_proto_version = SslVersion::TLS1_1,
"VersionTLS12" => min_proto_version = SslVersion::TLS1_2,
"VersionTLS13" => min_proto_version = SslVersion::TLS1_3,
_ => min_proto_version = SslVersion::TLS1,
}
ctx.set_min_proto_version(Some(min_proto_version))?;
let dh = Dh::params_from_pem(FFDHE_2048.as_bytes())?;
ctx.set_tmp_dh(&dh)?;
setup_curves(&mut ctx)?;
ctx.set_cipher_list(ciphersuites.replace(",", ":").as_str())?;
#[cfg(ossl111)]
ctx.set_ciphersuites(
"TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256",
)?;
Ok(SslAcceptorBuilder(ctx))
}

/// Creates a new builder configured to connect to non-legacy clients. This should generally be
/// considered a reasonable default choice.
///
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
8 changes: 8 additions & 0 deletions src/tls/incoming.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ impl TlsSettings {
match self.identity {
None => Err(TlsError::MissingRequiredIdentity),
Some(_) => {
if let Some(min_tls_version) = &self.min_tls_version {
if let Some (ciphersuites) = &self.ciphersuites {
let mut acceptor = SslAcceptor::custom(SslMethod::tls(), min_tls_version, ciphersuites)
.context(CreateAcceptorSnafu)?;
self.apply_context(&mut acceptor)?;
return Ok(acceptor.build())
}
}
let mut acceptor = SslAcceptor::mozilla_intermediate_v5(SslMethod::tls())
.context(CreateAcceptorSnafu)?;
self.apply_context(&mut acceptor)?;
Expand Down
6 changes: 6 additions & 0 deletions src/tls/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ pub struct TlsOptions {
#[serde(alias = "key_path")]
pub key_file: Option<PathBuf>,
pub key_pass: Option<String>,
pub min_tls_version: Option<String>,
pub ciphersuites: Option<String>,
}

impl TlsOptions {
Expand All @@ -89,6 +91,8 @@ pub struct TlsSettings {
pub(super) verify_hostname: bool,
authorities: Vec<X509>,
pub(super) identity: Option<IdentityStore>, // openssl::pkcs12::ParsedPkcs12 doesn't impl Clone yet
pub min_tls_version: Option<String>,
pub ciphersuites: Option<String>,
}

#[derive(Clone)]
Expand Down Expand Up @@ -125,6 +129,8 @@ impl TlsSettings {
verify_hostname: options.verify_hostname.unwrap_or(!for_server),
authorities: options.load_authorities()?,
identity: options.load_identity()?,
min_tls_version: options.min_tls_version.clone(),
ciphersuites: options.ciphersuites.clone(),
})
}

Expand Down