Remove files beyond compare doesnt do a good job handling (#283)

VerifyTests · May 13, 2022 · 39057bb · 39057bb
1 parent 6f5b144
commit 39057bb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 16 deletions.
diff --git a/docs/diff-tool.md b/docs/diff-tool.md
@@ -124,7 +124,7 @@ Non-MDI tools are preferred since it allows [DiffEngineTray](tray.md) to track a
   * Is MDI: False
   * Supports auto-refresh: True
   * Supports text files: True
-  * Supported binaries: mp3, xls, xlsm, xlsx, doc, docm, docx, dot, dotm, dotx, pdf, bmp, gif, ico, jpg, jpeg, png, tif, tiff, rtf
+  * Supported binaries: pdf, bmp, gif, ico, jpg, jpeg, png, tif, tiff, rtf
 
 #### Notes:
 
@@ -636,7 +636,7 @@ Non-MDI tools are preferred since it allows [DiffEngineTray](tray.md) to track a
 
 #### Notes:
 
- * [Command line reference](https://www.devart.com/codecompare/docs/index.html?comparing_via_command_line.htm)
+ * [Command line reference](https://docs.devart.com/code-compare/using-command-line/comparing-via-command-line.html)
 
 #### Windows settings:
 

diff --git a/src/DiffEngine.Tests/DiffEngine.Tests.csproj b/src/DiffEngine.Tests/DiffEngine.Tests.csproj
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net5.0;net6.0;netcoreapp3.1;netcoreapp2.1</TargetFrameworks>
-    <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net5.0;net6.0;netcoreapp3.1;netcoreapp2.1;net48</TargetFrameworks>
+    <TargetFrameworks>net5.0;net6.0;netcoreapp3.1</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net5.0;net6.0;netcoreapp3.1;net48</TargetFrameworks>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
     <NoWarn>SYSLIB0012</NoWarn>
   </PropertyGroup>

diff --git a/src/DiffEngine.Tests/diffTools.include.md b/src/DiffEngine.Tests/diffTools.include.md
@@ -13,7 +13,7 @@ Non-MDI tools are preferred since it allows [DiffEngineTray](tray.md) to track a
   * Is MDI: False
   * Supports auto-refresh: True
   * Supports text files: True
-  * Supported binaries: mp3, xls, xlsm, xlsx, doc, docm, docx, dot, dotm, dotx, pdf, bmp, gif, ico, jpg, jpeg, png, tif, tiff, rtf
+  * Supported binaries: pdf, bmp, gif, ico, jpg, jpeg, png, tif, tiff, rtf
 
 #### Notes:
 
@@ -525,7 +525,7 @@ Non-MDI tools are preferred since it allows [DiffEngineTray](tray.md) to track a
 
 #### Notes:
 
- * [Command line reference](https://www.devart.com/codecompare/docs/index.html?comparing_via_command_line.htm)
+ * [Command line reference](https://docs.devart.com/code-compare/using-command-line/comparing-via-command-line.html)
 
 #### Windows settings:
 

diff --git a/src/DiffEngine/Implementation/BeyondCompare.cs b/src/DiffEngine/Implementation/BeyondCompare.cs
@@ -34,16 +34,6 @@ static string TargetRightOsxLinuxArguments(string temp, string target)
             requiresTarget: true,
             binaryExtensions: new[]
             {
-                "mp3", //?
-                "xls",
-                "xlsm",
-                "xlsx",
-                "doc",
-                "docm",
-                "docx",
-                "dot",
-                "dotm",
-                "dotx",
                 "pdf",
                 "bmp",
                 "gif",
-Original file line number
+Diff line change
@@ Expand Up @@
                 requiresTarget: true,
                 binaryExtensions: new[]
                 {
-                    "mp3", //?
-                    "xls",
-                    "xlsm",
-                    "xlsx",
-                    "doc",
-                    "docm",
-                    "docx",
-                    "dot",
-                    "dotm",
-                    "dotx",
                     "pdf",
                     "bmp",
                     "gif",
@@ Expand Down @@