Fix error when YouTube API doesn't return video duration (#412)

VerifiedJoseph · Nov 3, 2024 · 9f2223f · 9f2223f
1 parent 2fbd541
commit 9f2223f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/include/Data.php b/include/Data.php
@@ -205,7 +205,7 @@ public function updateVideos($response): void
                 $key = array_search($item->id, array_column($this->data['videos'], 'id'));
                 $video = $this->data['videos'][$key];
 
-                $video['duration'] = Convert::videoDuration($item->contentDetails->duration);
+                $video['duration'] = Convert::videoDuration($item->contentDetails->duration ?? '');
                 $video['tags'] = array();
                 $video['premiere'] = false;
                 $video['stream'] = false;

diff --git a/include/Helper/Convert.php b/include/Helper/Convert.php
@@ -47,7 +47,7 @@ class Convert
     public static function videoDuration(string $duration, bool $allowNegative = true)
     {
         $matches = array();
-        $text = 'Unknown';
+        $text = 'Unknown duration';
 
         if (preg_match(self::$iso8601Regex, $duration, $matches)) {
             foreach ($matches as &$match) {

diff --git a/tests/Helper/ConvertTest.php b/tests/Helper/ConvertTest.php
@@ -12,7 +12,7 @@ class ConvertTest extends TestCase
      */
     public function testVideoDuration(): void
     {
-        self::assertEquals('Unknown', Convert::videoDuration('text'));
+        self::assertEquals('Unknown duration', Convert::videoDuration('text'));
         self::assertEquals('03:45', Convert::videoDuration('PT3M45S'));
         self::assertEquals('01:33:05', Convert::videoDuration('PT1H33M5S'));
         self::assertEquals('10:00:05', Convert::videoDuration('PT10H5S'));