fix: make printer for query generation more efficient #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should avoid building the resulting query string with `format` repeatedly, because `format` creates an entirely new string in each invocation. When the query is big, the cost is prohibitively expensive. This commit instead builds the query string by writing to a string port directly (similar to the StringBuilder idiom in languages like Java). As the fix needs to be done on Z3, cvc4, and cvc5, I also take an opportunity to refactor them to reduce code redundancy.
sorawee
added a commit
that referenced
this pull request
Jan 31, 2024
* chore: clean up indentation * logging: log inferred known vars
sorawee
added a commit
to sorawee/Picus
that referenced
this pull request
Mar 8, 2024
* chore: clean up indentation * logging: log inferred known vars
sorawee
added a commit
that referenced
this pull request
Mar 13, 2024
* chore: clean up indentation * logging: log inferred known vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should avoid building the resulting query string with
formatrepeatedly, becauseformatcreates an entirely new string in each invocation. When the query is big, the cost is prohibitively expensive.This commit instead builds the query string by writing to a string port directly (similar to the StringBuilder idiom in languages like Java). As the fix needs to be done on Z3, cvc4, and cvc5, I also take an opportunity to refactor them to reduce code redundancy.