Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing warnings #5

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Fixing warnings #5

merged 2 commits into from
Dec 31, 2024

Conversation

vhavlena
Copy link
Collaborator

@vhavlena vhavlena commented Dec 22, 2024 •
edited
Loading

This PR fixes compilation warnings (at least for clang).

@vhavlena vhavlena marked this pull request as ready for review December 23, 2024 22:04
@vhavlena
Copy link
Collaborator Author

@OndrejAlexaj could you please run the inclusion experiments? Just to be sure that it doesn't introduce any error.

@OndrejAlexaj
Copy link
Collaborator

@OndrejAlexaj could you please run the inclusion experiments? Just to be sure that it doesn't introduce any error.

All experiments successfully passed.

OndrejAlexaj
OndrejAlexaj approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@OndrejAlexaj OndrejAlexaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled with clang, ran all tests. Results are essentially the same as before. All tests passed successfully

@vhavlena vhavlena merged commit 3e70883 into devel Dec 31, 2024
2 checks passed
@vhavlena vhavlena deleted the fix-warnings branch December 31, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OndrejAlexaj OndrejAlexaj OndrejAlexaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vhavlena @OndrejAlexaj