Fix warnings (#469)

Sources/Verge/Library/EventEmitter.swift

@@ -19,7 +19,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
-@_implementationOnly import Atomics
+import Atomics
 import Combine
 import Foundation
 import os

Sources/Verge/Library/StoreActivitySubscription.swift

@@ -1,5 +1,5 @@
 import Combine
-@_implementationOnly import Atomics
+import Atomics
 
 /**
  A subscription that is compatible with Combine’s Cancellable.

Sources/Verge/Library/StoreStateSubscription.swift

@@ -1,5 +1,5 @@
 import Combine
-@_implementationOnly import Atomics
+import Atomics
 
 @available(*, deprecated, message: "StoreSubscription has separated into StoreStateSubscription and StoreActivitySubscription.")
 public typealias StoreSubscription = Cancellable

Sources/Verge/Library/VergeAnyCancellable.swift

@@ -1,5 +1,5 @@
 import Combine
-@_implementationOnly import Atomics
+import Atomics
 
 /// A typealias to `Set<AnyCancellable>`.
 public typealias VergeAnyCancellables = Set<AnyCancellable>

Sources/Verge/Store/AnyTargetQueue.swift

@@ -20,7 +20,7 @@
 // THE SOFTWARE.
 
 import Foundation
-@_implementationOnly import Atomics
+import Atomics
 
 public protocol TargetQueueType {
   func execute(_ workItem: @escaping () -> Void)

Sources/Verge/Store/Changes.swift

@@ -340,6 +340,33 @@ extension Changes {
 
   }
 
+  @inline(__always)
+  fileprivate func _takeIfChanged_packed_nonEquatable<each Element>(
+    _ compose: (Value) throws -> (repeat each Element),
+    comparator: some Comparison<(repeat each Element)>
+  ) rethrows -> (repeat each Element)? {
+
+    let current = self.primitive
+
+    guard let previousValue = previous else {
+      return try compose(consume current)
+    }
+
+    let old = previousValue.primitive
+
+    let composedFromCurrent = try compose(consume current)
+    let composedFromOld = try compose(old)
+
+    let isEqual = comparator(composedFromOld, composedFromCurrent)
+
+    guard isEqual == false else {
+      return nil
+    }
+
+    return composedFromCurrent
+
+  }
+
   /// Performs a closure if the selected value changed from the previous one.
   ///
   /// - Parameters:
@@ -376,6 +403,7 @@ extension Changes {
   /**
    Performs a closure if the selected value changed from the previous one.
    */
+  @available(*, deprecated, message: "Use another function that returns IfChangedBox")
   public func ifChanged<T, Result>(
     _ selector: ChangesKeyPath<T>,
     _ comparer: some Comparison<T>,
@@ -416,6 +444,17 @@ extension Changes {
     return .init(value: (repeat each result))
   }
 
+  public borrowing func ifChanged<each Element>(
+    _ compose: (borrowing Value) -> (repeat each Element),
+    comparator: some Comparison<(repeat each Element)>
+  ) -> IfChangedBox<(repeat each Element)> {
+    guard let result = _takeIfChanged_packed_nonEquatable(compose, comparator: comparator) else {
+      return .init()
+    }
+
+    return .init(value: (repeat each result))
+  }
+
   /**
    singular variant
    */

Sources/Verge/Store/Store.swift

@@ -23,7 +23,7 @@ import Foundation
 import os.log
 import ConcurrencyTaskManager
 
-@_implementationOnly import Atomics
+import Atomics
 
 #if canImport(Combine)
 import Combine

Sources/Verge/SwiftUI/OnReceive.swift

@@ -22,8 +22,18 @@ extension View {
   /// - Parameters:
   ///   - instance: The `DispatcherType` instance to subscribe to.
   ///   - perform: A closure to execute when the `State` changes.
-  public func onReceiveState<D: StoreDriverType>(_ instance: D, perform: @escaping @MainActor (Changes<D.TargetStore.State>) -> Void) -> some View {
-    onReceive(instance.store.asStore()._statePublisher().receive(on: DispatchQueue.main), perform: perform)
+  public func onReceiveState<D: StoreDriverType>(
+    _ instance: D,
+    perform: @escaping @MainActor (Changes<D.TargetStore.State>) -> Void
+  ) -> some View {
+    onReceive(
+      instance.store.asStore()._statePublisher().receive(on: DispatchQueue.main),
+      perform: { value in
+        MainActor.assumeIsolated {
+          perform(value)
+        }
+      }
+    )
   }
 
   /// Adds an action to perform when the specified `DispatcherType` publishes an activity.
@@ -46,8 +56,18 @@ extension View {
   /// - Parameters:
   ///   - instance: The `DispatcherType` instance to subscribe to.
   ///   - perform: A closure to execute when the `Activity` is published.
-  public func onReceiveActivity<D: StoreDriverType>(_ instance: D, perform: @escaping @MainActor (D.TargetStore.Activity) -> Void) -> some View {
-    onReceive(instance.store.asStore()._activityPublisher().receive(on: DispatchQueue.main), perform: perform)
+  public func onReceiveActivity<D: StoreDriverType>(
+    _ instance: D,
+    perform: @escaping @MainActor (D.TargetStore.Activity) -> Void
+  ) -> some View {
+    onReceive(
+      instance.store.asStore()._activityPublisher().receive(on: DispatchQueue.main),
+      perform: { value in
+        MainActor.assumeIsolated {
+          perform(value)
+        }
+      }
+    )
   }
 
 }

Sources/Verge/SwiftUI/StoreObject.swift

@@ -111,7 +111,7 @@ enum Preview_StoreObject: PreviewProvider {
     }
   }
 
-  final class ViewModel: StoreComponentType {
+  final class ViewModel: StoreDriverType {
 
     struct State: Equatable {
       var count: Int = 0

Sources/Verge/Utility/Edge.swift

@@ -20,7 +20,7 @@
 // THE SOFTWARE.
 
 import Foundation
-@_implementationOnly import Atomics
+import Atomics
 
 public protocol EdgeType : Equatable {
   associatedtype State

Sources/VergeComparator/PackedCompare.swift

@@ -4,7 +4,6 @@ public func areEqual<each Element: Equatable>(_ lhs: (repeat each Element), _ rh
 
   // https://github.com/apple/swift-evolution/blob/main/proposals/0408-pack-iteration.md
 
-
   func isEqual<T: Equatable>(_ left: T, _ right: T) throws {
     if left == right {
       return
@@ -21,3 +20,4 @@ public func areEqual<each Element: Equatable>(_ lhs: (repeat each Element), _ rh
 
   return true
 }
+

Sources/VergeNormalization/Tables/TableType.swift

@@ -1,7 +1,7 @@
 import VergeTypedIdentifier
 
 /// a storage of the entity
-public protocol TableType<Entity>: Equatable {
+public protocol TableType<Entity>: Equatable, Sendable {
 
   associatedtype Entity: EntityType
 

Sources/VergeRx/Store+Rx.swift

@@ -41,7 +41,7 @@ extension Reactive where Base : StoreDriverType {
 
 }
 
-extension StoreWrapperType {
+extension StoreDriverType {
 
   @_disfavoredOverload
   public var rx: Reactive<Self> {

Tests/VergeNormalizationDerivedTests/CombiningTests.swift

@@ -40,7 +40,7 @@ final class CombiningTests: XCTestCase {
       $0.count += 1
     }
 
-    store.commit {
+    _ = store.commit {
       $0.db.performBatchUpdates { t in
         t.modifying.author.insert(Author(rawID: "1", name: "Hiroshi Kimura"))
       }

Tests/VergeTests/DerivedTests.swift

@@ -122,11 +122,11 @@ final class DerivedTests: XCTestCase {
 
       updateCount.fulfill()
 
-      changes.ifChanged(\.0) { _0 in
+      changes.ifChanged(\.0).do { _0 in
         update0.fulfill()
       }
 
-      changes.ifChanged(\.1) { _1 in
+      changes.ifChanged(\.1).do { _1 in
         update1.fulfill()
       }
 

Tests/VergeTests/StoreAndDerivedTests.swift

@@ -8,7 +8,7 @@ final class StoreAndDerivedTests: XCTestCase {
 
     let store = Store<_, Never>(initialState: DemoState())
 
-    let nameDerived = store.derived(.select(\.name))
+    let _ = store.derived(.select(\.name))
     let countDerived = store.derived(.select(\.count))
 
     await withTaskGroup(of: Void.self) { group in

Tests/VergeTests/StoreMiddlewareTests.swift

@@ -8,13 +8,13 @@ final class StoreMiddlewareTests: XCTestCase {
     let store = DemoStore()
 
     store.add(middleware: .modify { @Sendable modifyingState, current in
-      current.ifChanged(\.count) { _ in
+      current.ifChanged(\.count).do { _ in
         modifyingState.count += 1
       }
     })
 
     store.add(middleware: .modify { @Sendable modifyingState, current in
-      current.ifChanged(\.name) { _ in
+      current.ifChanged(\.name).do { _ in
         modifyingState.count = 100
       }
     })

Tests/VergeTests/SyntaxTests.swift

@@ -17,23 +17,22 @@ enum SyntaxTests {
 
     let changes: Changes<DemoState> = .init(old: nil, new: .init())
 
-    changes.ifChanged(\.name) { name in
+    changes.ifChanged(\.name).do { name in
 
     }
 
 //    changes.ifChanged({ ($0.name, $0.name) }) { args in
 //    }
 
-    changes.ifChanged(\.nonEquatable, .alwaysFalse()) { name in
+    changes.ifChanged({ $0.nonEquatable }, comparator: .alwaysFalse()).do { name in
 
     }
 
-
-    changes.ifChanged({ $0.name }) { name in
+    changes.ifChanged({ $0.name }).do { name in
 
     }
 
-    changes.ifChanged(\.name, \.count) { name, count in
+    changes.ifChanged(\.name, \.count).do { name, count in
 
     }
 

Tests/VergeTests/Usage.swift

@@ -40,7 +40,7 @@ final class SpecificService: StoreDriverType {
 
 }
 
-final class ViewModel: StoreComponentType {
+final class ViewModel: StoreDriverType {
 
   struct State: Equatable {}
 
@@ -62,7 +62,7 @@ final class ViewModel: StoreComponentType {
 
 // MARK: - Abstraction
 
-protocol MyViewModelType: StoreComponentType where TargetStore.State == String, TargetStore.Activity == Int {
+protocol MyViewModelType: StoreDriverType where TargetStore.State == String, TargetStore.Activity == Int {
 
 }