Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose match spans via new method #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matanox
Copy link

@matanox matanox commented Dec 3, 2017

Enables #63.
Obviously this is too opinionated, so I doubt you'll merge this. But it is helpful to have this added control, as the original implementation seems to conceal retrieving the spans.

I've no idea why my editor added the superfluous white-space differences in the diff, but these can be easily undone if this gets a green light to merge.

Basically I've added a method getAllGroupSpans exposing the java.util.regex object holding the spans.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 99.359% when pulling 32d0b63 on matanster:master into f311b15 on VerbalExpressions:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants