Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Message Colors #2521

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

henmalib
Copy link
Contributor

@henmalib henmalib commented May 29, 2024

Displays hex/rgb/hsl colors in messages with a tiny-colored box nearby :3

I might have made some bad code especially with dynamic element creation, so I would be glad to get roasted

Also includes a color-picker
image

scripts/generateReport.ts Outdated Show resolved Hide resolved
src/plugins/messageColors/constants.ts Outdated Show resolved Hide resolved
@henmalib henmalib force-pushed the plugin_message_colors branch from ea3b643 to 708426c Compare June 3, 2024 16:33
@Vendicated Vendicated force-pushed the dev branch 3 times, most recently from 88319e8 to aaba22f Compare June 9, 2024 02:09
@byeoon
Copy link
Contributor

byeoon commented Jun 12, 2024

A nice addition to this would be the ability to have the colors highlight over the value. For example #ff0000 would be highlighted as red over the text. (As a custom setting to switch between box / highlight)

@henmalib
Copy link
Contributor Author

A nice addition to this would be the ability to have the colors highlight over the value. For example #ff0000 would be highlighted as red over the text. (As a custom setting to switch between box / highlight)

I forgot to mention it, but I already done this a few weeks ago

image

image

image

Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr, this is pretty cool!

i am unsure about the usefulness of the colour picker. i cannot imagine a scenario where you'd need to pick a specific colour to send in a discord chat?

the background option looks terrible and unreadable in its current state, it would be nice to dynamically pick either white or black text depending on which has better contrast

src/plugins/messageColors/ColorPicker.tsx Outdated Show resolved Hide resolved
src/plugins/messageColors/ColorPicker.tsx Outdated Show resolved Hide resolved
src/plugins/messageColors/constants.ts Outdated Show resolved Hide resolved
src/plugins/messageColors/constants.ts Outdated Show resolved Hide resolved
src/plugins/messageColors/constants.ts Show resolved Hide resolved
src/plugins/messageColors/index.tsx Outdated Show resolved Hide resolved
src/plugins/messageColors/index.tsx Outdated Show resolved Hide resolved
src/plugins/messageColors/index.tsx Outdated Show resolved Hide resolved
src/plugins/messageColors/index.tsx Outdated Show resolved Hide resolved
src/plugins/messageColors/constants.ts Outdated Show resolved Hide resolved
@henmalib
Copy link
Contributor Author

henmalib commented Sep 4, 2024

I love force push ( please discard changes for dearrow )
UPD: nvm, thanks, refined GitHub

Also, should I sacrifice a cockroach to get this moving? :pleadey:

@byeoon
Copy link
Contributor

byeoon commented Sep 8, 2024

I love force push ( please discard changes for dearrow )

Also, should I sacrifice a cockroach to get this moving? :pleadey:

go for it (randomly saw this pop up in my notifs so i hope it gets merged soon)

@henmalib henmalib changed the base branch from dev to main September 12, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants