Support for identity/GetMembers #87
Conversation
gdbarron
requested review from
gdbarron,
Saadi6,
brantpeery,
wilddev65,
astro2000j,
Pmaraveyias and
danguite-ven
VenafiPS/Public/Get-TppIdentity.ps1
Outdated
| $assocParams.UriLeaf = 'Identity/GetMembers' | ||
| $assocParams.Body.Add("ResolveNested","1"); | ||
| $members = Invoke-VenafiRestMethod @assocParams | ||
| $response | Add-Member @{ 'Members' = $members.Identities} |
There was a problem hiding this comment.
we should look for the response to be consistent. an identity typically consists of ID, Name and Path. $members.Identities returns quite a bit more than that
There was a problem hiding this comment.
The Identities returned by GetMembers is the same data returned by GetAssociatedEntries , it is an array of type "Identity Entry Object". So how is it not consistent ?
There was a problem hiding this comment.
It's not consistent with what Get-TppIdentity returns which is ID, Name, Path, and IsGroup. associated should be updated as well.
There was a problem hiding this comment.
Sure, I can make those updates.
VenafiPS/Public/Get-TppIdentity.ps1
Outdated
| if (($response.IsGroup) -and ($IncludeMembers)) { | ||
| $assocParams = $params.Clone() | ||
| $assocParams.UriLeaf = 'Identity/GetMembers' | ||
| $assocParams.Body.Add("ResolveNested","1"); |
There was a problem hiding this comment.
to keep consistent syntax
| $assocParams.Body.Add("ResolveNested","1"); | |
| $assocParams.Body.ResolveNested = '1' |
There was a problem hiding this comment.
I prefer the explicit syntax since it emphasizes that that is a new key, as opposed to simply updating an existing one. Coding wise I think that makes it easier to read . I can go either way though.
There was a problem hiding this comment.
Typically it's best to follow the convention of the existing code so it's all the same.
No description provided.