Minor bug fixes for issues #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdbarron
requested changes
Dec 12, 2022
There was a problem hiding this comment.
I don't think we should change ConvertTo-TppGuid. I can understand returning null when calling a Get function and the item doesn't exist, but ConvertTo requires an existing item to convert. If that item doesn't exist, that's an error imo. Same thing as a Set function. If the item you're updating doesn't exist, wouldn't we want to tell the user? If someone wants the functionality being requested, they can simply add -ErrorAction SilentlyContinue.
|
Okay, both changes have been committed as requested |
gdbarron
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConvertTo-TppGuid return null instead of an error when search result is empty (part of 170)
Invoke-VenafiCertificateAction always run as verbose (#173)
Set-TppAttribute gives error when using $null as value (#176)