Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch YaPB to upstream repository #74

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Switch YaPB to upstream repository #74

merged 4 commits into from
Mar 11, 2024

Conversation

jeefo
Copy link
Contributor

@jeefo jeefo commented Feb 19, 2024

Due to all the changes from yours's android fork is now in upstream, i believe it's time to change submodule URL to primary upstream repo.

Also changed some GH actions to suit changes with node20 requirement.

@Velaron
Copy link
Owner

Velaron commented Mar 11, 2024

TBH that CMakeLists was something i slapped in a few minutes and it was barely tested, maybe calling meson from CMake or smth would be more preferrable...

@jeefo
Copy link
Contributor Author

jeefo commented Mar 11, 2024

Well, I'm eventually going to replace default build system (meson) with a CMake, meson looks as overkill for that size of project.

Anyway I have modded your version a little bit, so it's do the work pretty much ok, even with git build info.

@Velaron Velaron merged commit 9d1fa6d into Velaron:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants