Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Documentation #659

Merged
merged 10 commits into from
Dec 24, 2024
Merged

📝 Documentation #659

merged 10 commits into from
Dec 24, 2024

Conversation

Vectorized
Copy link
Owner

@Vectorized Vectorized commented Oct 20, 2023

Description

For the sidebar, we want to have the following structure:

ACCOUNTS
- ERC4337
- ERC4337Factory
...
AUTH
- Ownable
- OwnableRoles
TOKENS
- ERC20 
...

Currently, it has the ERC721A docs. We will slowly replace the markdowns one by one to morph it.

Feel free to make a PR to this branch. Don't be shy. This is docs, so no risk of bugs.

Once we have around 30% of the stuff, we can consider merging into main.

Since it is too daunting to fill in all the markdowns at breakneck speed, we can simply create the planned markdowns first, and put a "Under Construction" placeholder.

Contributing

Since there may be multiple people working on the docs simultaneously, leave a comment on what you want to work on. This will prevent us from doing overlapping work.

Preview

Any pushes to this branch will be auto-deployed to:

https://vectorized.github.io/solady/

Motivation

Think of docs as a feature.

It elevates the quality of the repo all around.

It imbues an aura of prestige.

Documentation can include the nuances that are too bulky to be squeezed into the Natspec.

Making docs is one of the best way to get lots of green dots on your Github.
Remember to make multiple PRs (e.g. one PR for one markdown) if you wanna farm docs.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge snapshot?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@Vectorized Vectorized temporarily deployed to github-pages October 20, 2023 02:37 — with GitHub Pages Inactive
@ghost
Copy link

ghost commented Oct 20, 2023

Hi, I'd like to work on ERC20, ERC721 and WETH.

@PraneshASP
Copy link

Wow, this is sick!

@Vectorized Vectorized marked this pull request as ready for review December 23, 2024 12:36
Vectorized and others added 7 commits December 24, 2024 16:01
* updated sidebar w/ placeholders

* fixed broken link for libPRNG
* added ERC20 draft

* changed bullet point

* added example usage section

* added gas benchmarks and Api reference section

* fixed formatting

* added documentation up to totalSupply(), committing changes so I can see how it looks like

* fixed grammar and standardized structure

* added documentation for balanceOf and allowance

* added documentation for the approve function

* added documentation for transfer

* added revert condition for transfer function

* standardize

* Added documentation on nonces

* added documentation for permit

* added documentation for DOMAIN_SEPERATOR

* added section for events

* fixed events table format

* fixed small typo

* added benchmarks for ERC20
@Vectorized
Copy link
Owner Author

Screw it, let's merge.

@Vectorized Vectorized merged commit 2d85958 into main Dec 24, 2024
3 checks passed
@Vectorized Vectorized deleted the docs branch December 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants