Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor SignatureCheckLib #1261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

♻️ Refactor SignatureCheckLib #1261

wants to merge 1 commit into from

Conversation

atarpara
Copy link
Collaborator

@atarpara atarpara commented Jan 4, 2025

Description

Added oz style codesize checker

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@atarpara atarpara requested a review from Vectorized January 4, 2025 06:24
Copy link

github-actions bot commented Jan 4, 2025

Gas Snapshot Comparison Report

Generated at commit : f9ae978, Compared to commit : de9aee5

Contract Name Test Name Main Gas PR Gas Diff
ERC1271Test testIsValidSignature() 3061415 3060589 -826
test__codesize() 30594 30604 10
ERC4337FactoryTest test__codesize() 13107 13112 5
ERC4337Test testDisableInitializerForImplementation() 1346451 1347451 1000
testIsValidSignature() 119600 118982 -618
testIsValidSignatureViaRPC() 96881547 96881538 -9
testIsValidSignatureWrapped() 490305 487138 -3167
testOwnerRecovery() 479627 482237 2610
testValidateUserOp() 484764 484730 -34
test__codesize() 56023 56028 5
ERC6551Test test__codesize() 50886 50896 10
SignatureCheckerLibTest testEmptyCalldataHelpers() 3918 655 -3263
testSignatureCheckerOnEOAWithInvalidSignature() 21362 20674 -688
testSignatureCheckerOnEOAWithInvalidSigner() 30862 18174 -12688
testSignatureCheckerOnEOAWithMatchingSignerAndSignature() 17760 20696 2936
testSignatureCheckerOnEOAWithWrongSignedMessageHash() 21386 20698 -688
testSignatureCheckerOnMaliciousWallet() 31953 22314 -9639
testSignatureCheckerOnWalletWithInvalidSignature() 78992 69353 -9639
testSignatureCheckerOnWalletWithInvalidSigner() 26095 16456 -9639
testSignatureCheckerOnWalletWithMatchingSignerAndSignature() 66073 56434 -9639
testSignatureCheckerOnWalletWithWrongSignedMessageHash() 66127 56488 -9639
test__codesize() 18875 18891 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant