Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Add extra check for decodeBatch #1244

Merged
merged 5 commits into from
Dec 19, 2024
Merged

♻️ Add extra check for decodeBatch #1244

merged 5 commits into from
Dec 19, 2024

Conversation

Vectorized
Copy link
Owner

@Vectorized Vectorized commented Dec 18, 2024 •
edited
Loading

Description

I hope no more hidden gotchas.

Letting this marinate for maybe a day first.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Gas Snapshot Comparison Report

Generated at commit : 580419f, Compared to commit : 0dfa997

Contract Name Test Name Main Gas PR Gas Diff
LibERC7579Test testDecodeBatchEdgeCase() 7770 7785 15
test__codesize() 13133 13651 518
testDecodeBatchEdgeCase2() - 24645 -
TimelockTest testOpenRoleHolder() 215769 215799 30
testPredecessor() 234970 235000 30
test__codesize() 19459 19467 8

@Vectorized Vectorized merged commit 740812c into main Dec 19, 2024
11 checks passed
@Vectorized Vectorized deleted the 7579-final-please branch December 24, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vectorized