Always share attributes with underlying session instance #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an existing session instance was passed into create_scraper, interesting attributes were copied if they were truthy. However, this excluded copying attributes of mutable data types that were falsey at the time. For example, if the cookie jar of the original session was empty, then cloudscraper wouldn't use the same jar as the original session and cookies would get out of sync between the two. Now all interesting attributes are synced given they aren't None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an existing session instance was passed into create_scraper,
interesting attributes were copied if they were truthy. However, this
excluded copying attributes of mutable data types that were falsey at
the time. For example, if the cookie jar of the original session was
empty, then cloudscraper wouldn't use the same jar as the original
session and cookies would get out of sync between the two.
Now all interesting attributes are synced given they aren't None.