Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

[FIX] travis: apply patch for duplicate-code issue for any pylint version #318

Merged

Conversation

fernandahf
Copy link

Description of the issue/feature this PR addresses:

The duplicate-code (R0801) can't be disabled
More information: pylint-dev/pylint#214

Current behavior before PR:
duplicated-code check can't be disabled.

Desired behavior after PR is merged:
duplicated-code check can be disabled.

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@fernandahf
Copy link
Author

@moylop260

Could you review this, please?

Regards.

@moylop260
Copy link

Could you make a PR dummy in order to test this one, please?

@moylop260
Copy link

FYI I have created a t2d using this dev branch

And the original patch is outdated since that it is failing applying the first hunk

added 8 packages from 7 contributors, removed 5 packages and updated 21 packages in 15.757s
python -c "from __future__ import print_function; from pylint.checkers import similar; print(similar.__file__.rstrip('c'))"
patching file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py
Hunk #1 FAILED at 46.
Hunk #2 succeeded at 64 (offset 4 lines).
Hunk #3 succeeded at 157 with fuzz 1 (offset 4 lines).
Hunk #4 succeeded at 178 with fuzz 1 (offset 4 lines).
Hunk #5 succeeded at 214 (offset 4 lines).
Hunk #6 succeeded at 377 (offset 4 lines).
1 out of 6 hunks FAILED -- saving rejects to file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py.rej

Could you overwrite the patch with an updated one, please?

@moylop260
Copy link

@fernandahf fernandahf force-pushed the master-apply-patch-new-version-pylint-fer branch from 537fc12 to 242b895 Compare January 20, 2021 15:50
@fernandahf
Copy link
Author

FYI I have created a t2d using this dev branch

And the original patch is outdated since that it is failing applying the first hunk

added 8 packages from 7 contributors, removed 5 packages and updated 21 packages in 15.757s
python -c "from __future__ import print_function; from pylint.checkers import similar; print(similar.__file__.rstrip('c'))"
patching file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py
Hunk #1 FAILED at 46.
Hunk #2 succeeded at 64 (offset 4 lines).
Hunk #3 succeeded at 157 with fuzz 1 (offset 4 lines).
Hunk #4 succeeded at 178 with fuzz 1 (offset 4 lines).
Hunk #5 succeeded at 214 (offset 4 lines).
Hunk #6 succeeded at 377 (offset 4 lines).
1 out of 6 hunks FAILED -- saving rejects to file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py.rej

Could you overwrite the patch with an updated one, please?

Done

@moylop260
Copy link

Could you make a dummy PR using this branch and using python2.7 and another using python3.6, please?

@fernandahf fernandahf force-pushed the master-apply-patch-new-version-pylint-fer branch from 242b895 to f9d31aa Compare January 20, 2021 20:26
…sion

This patch is to fix an issue about pylint disable in duplicate-code, related to PR pylint-dev/pylint#1055, this patch works in pylint versions >= 2.2.0
@fernandahf fernandahf force-pushed the master-apply-patch-new-version-pylint-fer branch from f9d31aa to 82700ab Compare January 21, 2021 19:46
Copy link

@moylop260 moylop260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@moylop260 moylop260 merged commit 16388c1 into Vauxoo:master Jan 21, 2021
@moylop260 moylop260 deleted the master-apply-patch-new-version-pylint-fer branch January 21, 2021 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants