Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to make the long provisioning warning be a bear. (and also provide more accurate information) #2506

Merged
merged 7 commits into from
Jul 30, 2021

Conversation

bradp
Copy link
Contributor

@bradp bradp commented Jul 28, 2021

Updates the character that warns you the first provision is long to be a bear.

tea-time

Also updated the text, because previously, it suggests running vagrant up if you only wanted to turn on VVV, but the first time you do a vagrant up, if you haven't provisioned, you'd see this message. So now it's a bit more clear hopefully.

I kept the output as inline in the Vagrantfile, but happy to split into a separate file if we want.

Also look how cute they are with their lil tea mug, even sitting on a little table

    default: Running: inline script
    default:     
    default:                                       A full provision will take a bit.
    default:     ▄▀▀▀▄▄▄▄▄▄▄▀▀▀▄          ▄   ▄    Sit back, relax, and have some tea.
    default:     █▒▒░░░░░░░░░▒▒█         █   █
    default:      █░░█░░░░░█░░█         ▀   ▀      If you keep seeing this message,
    default:   ▄▄  █░░░▀█▀░░░█  ▄▄  ▄▀▀█▀▀▀▀▀▀█    make sure you're running 'vagrant up'
    default:  █░░█ ▀▄░░░░░░░▄▀ █░░█ █  █      █
    default: ─────────────────────── ▀▀█      █ ───────────────
    default:                            ▀▄▄▄▄▀
    default:
==> default: Running provisioner: default (shell)...
    default: Running: /var/folders/86/w0vt5r5x4n369p808m9py51c0000gn/T/vagrant-shell20210728-66392-crly12.sh
    default:  - skipping ntpdate clock sync, not installed yet
    default:  ✔  ▷ Running the 'main' provisioner

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@update-docs
Copy link

update-docs bot commented Jul 28, 2021

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@bradp
Copy link
Contributor Author

bradp commented Jul 28, 2021

For context, here's the old version of what was there. As cute as it is, a bit out of place with all the bears

༼ つ ◕_◕ ༽つ A full provision can take a little while!
             Go make a cup of tea and sit back.
             If you only wanted to turn VVV on, use vagrant up

@tomjn
Copy link
Member

tomjn commented Jul 29, 2021

Some notes:

  • we have variables in the vagrant file for colours and resets that can make this nicer in code
  • kill the bottom of the coffee cup and move it over so it overlaps a bit, we can get rid of the right hand of the bear
  • max of 1 line of empty space after and before
  • we can probablly shorten or adjust the text, doesn't need to be a separate colour
  • we should check on terminals with white backgrounds

@tomjn tomjn added this to the 3.8 milestone Jul 29, 2021
@bradp
Copy link
Contributor Author

bradp commented Jul 29, 2021

  • we have variables in the vagrant file for colours and resets that can make this nicer in code

Unfortunately, they aren't able to be used in the context where this is set, as we're passing an inline bash command, so we don't have access to the Vagrantfile variables. Could be possible to build the string up separately and then pass it, but that's probably overkill just for these colors.

Updated bear:
Screen Shot 2021-07-29 at 3 05 48 PM

These are the default Terminal themes, and they all look good. Taking the color off the text helps, because now it's just the cyan/blue bear, which is used in vagrant halt and the other hooks.
Screen Shot 2021-07-29 at 3 05 33 PM

Also, let me know what you think of the coffee cup this way, and if you wanna change it, mind just drawing what you're thinking over that one?

@bradp
Copy link
Contributor Author

bradp commented Jul 30, 2021

lmao im an idiot

@tomjn
Copy link
Member

tomjn commented Jul 30, 2021

coffee cup looks good

@tomjn
Copy link
Member

tomjn commented Jul 30, 2021

Just needs a changelog update then it can be merged

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Matias Saggiorato <[email protected]>
@tomjn tomjn merged commit dc3633a into Varying-Vagrant-Vagrants:develop Jul 30, 2021
@davidwolfpaw davidwolfpaw mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants