Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an error in dashboard updating #2500

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Fix an error in dashboard updating #2500

merged 2 commits into from
Jul 27, 2021

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Jul 27, 2021 •
edited
Loading

Dashboard provisioning fails to update due to a popd and pushd that are the wrong way around

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@tomjn tomjn added the type:bug label Jul 27, 2021
@tomjn tomjn added this to the 3.7.2 milestone Jul 27, 2021
@update-docs
Copy link

update-docs bot commented Jul 27, 2021 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn marked this pull request as ready for review July 27, 2021 13:11
@tomjn tomjn requested a review from a team July 27, 2021 13:11
@tomjn tomjn merged commit 0212ae7 into develop Jul 27, 2021
@Mte90 Mte90 deleted the fix/dashboard-updates branch April 13, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mte90 Mte90 Mte90 approved these changes

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjn @Mte90