Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(noroot): on utilities #2392

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix(noroot): on utilities #2392

merged 1 commit into from
Mar 15, 2021

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Mar 15, 2021

Tested and works

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@Mte90 Mte90 requested a review from tomjn March 15, 2021 13:54
@update-docs
Copy link

update-docs bot commented Mar 15, 2021 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn
Copy link
Member

tomjn commented Mar 15, 2021

This looks good, does it handle when the files are already owned by root though? We don't want provisioning to halt because it can't write to those files

@Mte90
Copy link
Member Author

Mte90 commented Mar 15, 2021

This looks good, does it handle when the files are already owned by root though? We don't want provisioning to halt because it can't write to those files

I don't know about this case as I was destroying every time the VM.

@tomjn
Copy link
Member

tomjn commented Mar 15, 2021

Testing confirms it's not an issue

@tomjn tomjn merged commit 4c8bba3 into develop Mar 15, 2021
@tomjn tomjn added this to the 3.6 milestone Mar 15, 2021
@tomjn tomjn added the type:bug label Mar 15, 2021
@Mte90 Mte90 deleted the mte90/fix-utility-user branch July 14, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjn tomjn tomjn approved these changes

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Mte90 @tomjn