Printing backtrace ip for x86_64-fortanix-unknown-sgx #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrogb
reviewed
Dec 10, 2019
src/print.rs
Outdated
| true | ||
| } else { | ||
| false | ||
| }; |
There was a problem hiding this comment.
let mut print_frame_ip = PrintFmt::Full == self.fmt.format;There was a problem hiding this comment.
@jethrogb Fixed in current push.
VardhanThigle
force-pushed
the
Vardhan/fix_x86_64-fortanix-unknown-sgx
branch
from
553cf52
to
52c8c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1
As we do not support symbol resolution for this target, we need to always print the frame ip addresses for the backtrace, which can be converted later using addr2line