Skip to content

Commit

Permalink
Revert "Fix calico-node in etcd mode (kubernetes-sigs#10438)"
Browse files Browse the repository at this point in the history
This reverts commit 29ea790.

Check that CI still catches that bug with node-etcd-client
  • Loading branch information
VannTen committed Jan 11, 2024
1 parent 3a8f921 commit aca9b0d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
7 changes: 6 additions & 1 deletion roles/network_plugin/calico/templates/calico-config.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ data:
{% if calico_datastore == "kdd" %}
"datastore_type": "kubernetes",
"nodename": "__KUBERNETES_NODE_NAME__",
{% else %}
{% if cloud_provider is defined %}
"nodename": "{{ calico_kubelet_name.stdout }}",
{% else %}
"nodename": "{{ calico_baremetal_nodename }}",
{% endif %}
{% endif %}
"type": "calico",
"log_level": "info",
Expand Down Expand Up @@ -102,4 +108,3 @@ data:
}
]
}

7 changes: 0 additions & 7 deletions roles/network_plugin/calico/templates/calico-node.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,6 @@ spec:
# Prevents the container from sleeping forever.
- name: SLEEP
value: "false"
{% if calico_datastore == "etcd" %}
- name: ETCD_ENDPOINTS
valueFrom:
configMapKeyRef:
name: calico-config
key: etcd_endpoints
{% endif %}
{% if calico_datastore == "kdd" %}
# Set the hostname based on the k8s node name.
- name: KUBERNETES_NODE_NAME
Expand Down

0 comments on commit aca9b0d

Please sign in to comment.