Fix handling for ALG_ID_ECDH_P384 #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixes Anno 1800 multiplayer session negotiation
cachpachios
approved these changes
Mar 8, 2023
This was referenced Mar 9, 2023
Sulavius
approved these changes
Mar 9, 2023
|
this has been fixedin upstream wine already |
Do you have a commit hash for the fix? |
|
Closing as upstream fixed the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a missing case statement for handling ALG_ID_ECDH_P384.
This has at least fixed Anno 1800 multiplayer session negotiation, which did not work at all with Proton 7.0-6 (the one provided in Steam), but works like a charm after this patch has been applied to it.
The other PR (#173) adds extra code that is not required and already is present at line 1406 in wine/dlls/bcrypt/bcrypt_main.c