Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18.x tis-3d rendering+infared fixes #411

Merged
merged 21 commits into from
Feb 8, 2023
Merged

1.18.x tis-3d rendering+infared fixes #411

merged 21 commits into from
Feb 8, 2023

Conversation

walksanatora
Copy link
Contributor

@walksanatora walksanatora commented Feb 6, 2023

This fixes rendering issues on TIS-3D
meaning that TIS-3D can actually be used on ValkrienSkies ships now (AFAIK)

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2023

CLA assistant check
All committers have signed the CLA.

@walksanatora walksanatora changed the title 1.18.x tis-3d compat 1.18.x tis-3d rendering fixes Feb 6, 2023
@Rubydesic
Copy link
Contributor

Have you tested this compatibility outside of your dev environment? (by building the mod as a JAR and using it normally with TIS-3D)

@Rubydesic
Copy link
Contributor

I see some suspicious remap=false

@walksanatora
Copy link
Contributor Author

I was told to remap=false when targeting non-mc classes

@Rubydesic
Copy link
Contributor

Did you test it?

@walksanatora
Copy link
Contributor Author

within dev enviroment: yes
currently setting up the instance. (will test it in normal mc when i am on a transion period)

@walksanatora
Copy link
Contributor Author

okay after a quick test
rendering: fixed
infared: not fixed (does not work ship within ship, ship <-> world and ship <-> other ship are ValkComp things)
i need to figure out why infared is like this, but this makes TIS-3d atleast usable on ships (although not 100%)

@walksanatora
Copy link
Contributor Author

so inorder to fix the Infared i gotta fix a raycast
do you know if VSGameUtilsKt has a function to replace the raycast

@walksanatora
Copy link
Contributor Author

infared still broken, when i get home gonna run under a debugger (darn forgeGradle runClient not working with --offline)

@walksanatora
Copy link
Contributor Author

@Rubydesic Finally works
i tested and it works
the only reason why infared packets can miss is because you were going too fast or rotating too quickly (since they are pretty slow entities) but otherwise it works perfectly (even on rotated ships)

@walksanatora walksanatora changed the title 1.18.x tis-3d rendering fixes 1.18.x tis-3d rendering+infared fixes Feb 8, 2023
@Rubydesic Rubydesic merged commit adaef37 into ValkyrienSkies:1.18.x/main Feb 8, 2023
@walksanatora walksanatora deleted the 1.18.x/TIS-Compat branch February 8, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants