Assembly changes #340
Merged
Assembly changes #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Tested it on fabric, seems to work properly |
- relocateBlock has option to update blocks around it or not - updateBlock method to thoroughly update moved blocks - Assembly updates blocks separately after moving all of them (cherry picked from commit 9c6279b)
…te is set (cherry picked from commit 68e04d6)
(cherry picked from commit d23e987)
- Flag 64 and neighbor updates were causing blocks to break that shouldn't break. (cherry picked from commit 49f473a)
Rubydesic
force-pushed
the
1.18.x/assembly_changes
branch
from
334246c to
5fc10c3
Compare
ewoudje
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly changes from 1.16.5 main required for Eureka disassembly to work properly.
Tested on Forge, needs testing on Fabric.