[1.18.2] FTB Chunks Compatibility #291
Conversation
…ce to be tested against Edited build.gradle:common to add FTB Chunks, Utilities, and Teams, as well as the CurseMaven repository Edited valkyrienskies-common.mixins.json to add MixinClaimedChunkManager
| if (ship != null) { | ||
| final Vector3d vec = | ||
| ship.getShipToWorld().transformPosition(new Vector3d(pos.getX(), pos.getY(), pos.getZ())); | ||
| cir.setReturnValue(getChunk(new ChunkDimPos(entity.level, new BlockPos(vec.x, vec.y, vec.z)))); |
There was a problem hiding this comment.
Can you make this not trigger when vec.y is > max world Y or < min world Y? That way ships can fly over other factions claims.
common/build.gradle
Outdated
| @@ -1,3 +1,12 @@ | |||
| repositories { | |||
There was a problem hiding this comment.
Can you remove this section? The VS2 Maven will automatically shade the repository when it builds on github.
There was a problem hiding this comment.
Sadly, when I do, IntelliJ yells at me when I refresh Gradle
…low ships to fly over claimed chunks
|
Added Check for Min/Max Build Height to allow ships to fly over and under chunk claims to avoid being stuck in a claim |
|
Latest after my last change is broken for now and I am using a compupter that i cant test out of dev on |
Edited MixinClaimedChunkManager to change the position passed to the newly created ChunkDimPos instance for getChunk
… falling under claim's protection
|
This PR is now ready to be merged minus the CurseMaven repo that IntelliJ wont let me remove without losing the ability to build |
|
Can you add a config option for this behaviour? Otherwise lgtm |
…sable ships being protected and to disable ships being protected above/below build height
|
Config Options for toggling protection and protection outside of build height have been added |
Allows Ships to fall under the protection of FTB Chunks if the blocks are in said chunk!