Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release some memory leaks #721

Merged
merged 1 commit into from
Apr 27, 2021
Merged

fix: release some memory leaks #721

merged 1 commit into from
Apr 27, 2021

Conversation

arturovt
Copy link
Contributor

Currently, there are a lot of leaks:

image

Most leaks are coming from the pdfjs-dist package, it adds a lot of event listeners and never removes them:

image

By unreferencing loadingTask I was able to unreference some pdfjs-dist resources that were created by loadingTask internally.

@BioPhoton
Copy link

Hi! Any plans no when this gets released?

@VadimDez VadimDez added this to the 6.4.2 milestone Apr 27, 2021
@VadimDez VadimDez merged commit 0759872 into VadimDez:master Apr 27, 2021
@arturovt arturovt deleted the fix/leaks branch April 27, 2021 12:52
@VadimDez VadimDez modified the milestones: 6.4.2, 7.0.0 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimDez VadimDez VadimDez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arturovt @BioPhoton @VadimDez