Style fix for Issue #505 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomLaggna I see no difference regarding #505, do you see any differences? |
|
@VadimDez For comparison, the Image from #505 However, it seems that this commit broke it. |
seopei
suggested changes
Jun 27, 2020
| margin: 1px auto -8px auto; | ||
| position: relative; | ||
| overflow: visible; | ||
| border: 9px solid transparent; |
There was a problem hiding this comment.
you removed a bug fix for the borders for safari browsers. the original line was:
// https://stackoverflow.com/questions/21025212/border-image-not-showing-in-safari
// "transparent" makes the border not show up in Safari. But adding a light transparent color did
// rgba(0,0,0,0.01). But there needs to be an alpha value larger than 0.
border: 9px solid rgba(0,0,0,0.01);
VadimDez
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#505 Use the style directly from viewer.css (copied from PDF.js).