Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stacking context. fix #39 #43 #44

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Conversation

ghetolay
Copy link
Contributor

@ghetolay ghetolay commented Jan 8, 2017

When text is rendered canvas has a z-index of 1 to be kept under the text.
But because there is no stacking context anywhere inside <pdf-viewer> to encapsulate z-index, this can provoke unexpected behavior with user designs like in #39 and #43.

This is one possible fix, another one could be to set the text layer as position: absolute instead of the canvas and keep the default z-index behavior.

Workaround in the meantime :

 pdf-viewer {
   position: relative;
   z-index: 0;
 }

@VadimDez VadimDez merged commit a7b31f0 into VadimDez:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants