Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #408
The current method of listening to the
pagerendered
event using@HostListener
no longer works. This is becausePDFSinglePageViewer
now loads one page ahead of the current page. Since theevent.source.div
is not yet in the DOM, the@HostListener
fails.One solution to this is to listen to the
eventBus
fromcreateEventBus
directly in bothsetupMultipageViewer()
andsetupSinglePageViewer()
:This approach is very different from the current setup, and I am not sure what side effects it may cause. But it is the way recommended by the
pdf.js
devs: #10230.