Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress z-lib warning in angular6+ #409

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Conversation

ColinT
Copy link
Contributor

@ColinT ColinT commented Nov 7, 2018

This should fix issue-#322 (I accidentally named the branch incorrectly) and suppress the z-lib warning according to mozilla/pdf.js#9924 by updating to [email protected].

[email protected] adds browser: { 'zlib': false } to the npmManifest.

@ColinT ColinT mentioned this pull request Nov 7, 2018
@VadimDez
Copy link
Owner

VadimDez commented Nov 7, 2018

Unfortunately this is not enough. More changes on ng2-pdf-viewer side are required in order to be able to use 2.0.943. If you try running nom start with 2.0.943 you'll see that it's no really working.

@robeverett
Copy link

How do I suppress this z-lib warning using Angular 7 ?
I was re-directed here from other threads.

@ColinT
Copy link
Contributor Author

ColinT commented Nov 8, 2018

Sorry, I incorrectly assumed there would be no breaking changes due to the versioning syntax.

Latest commit should account for their refactor of PDFFindController. ng test passes.

Thanks for your guidance.

@dotNetAthlete This is a PR thread. You can find workarounds on the issue thread #322. I see you have already visited that thread but if you look higher up you will see solutions. You can discuss related issues there, and it will be more visible to others who are having the same problem.

@VadimDez VadimDez added this to the 5.2.2 milestone Nov 13, 2018
@VadimDez VadimDez merged commit 56a3e55 into VadimDez:master Nov 13, 2018
@ColinT ColinT deleted the issues-395 branch November 13, 2018 21:36
@Piotrovskyi
Copy link

Please release v5.2.2, or say when you suppose to do this. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 6 support
4 participants