Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFViewer way #36

Merged
merged 6 commits into from
Feb 2, 2017
Merged

PDFViewer way #36

merged 6 commits into from
Feb 2, 2017

Conversation

Vi-dot
Copy link

@Vi-dot Vi-dot commented Dec 9, 2016

New features :

  • TextLayer
  • LinkLayer
  • Fit component width (if !originalSize and call updateSize() )

This is the PDFViewer way, it's better than PDFPageView way. For those reasons :

  • Progressive loading of pages
  • TextLayer reload fine after scale
  • Rotation is working

There is only one bad thing : we cannot load only one page a time.
We can fix it by using PDFPageView for this case.

Notes :
_enhanceTextSelection & _pageBorder look useless. We may remove them.

Here is a Demo

@VadimDez
Copy link
Owner

Looks good! 😉 Definitely need one page at a time

@VadimDez VadimDez added this to the 1.0.0 milestone Dec 22, 2016
@damsorian
Copy link

Thanks!, I need this, the lazy loading is the best feature, my site takes a long time to load.

+1

@VadimDez VadimDez removed this from the 1.0.0 milestone Jan 23, 2017
@VadimDez VadimDez merged commit f6ac130 into VadimDez:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants