Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Angular 8 #482

Closed
Jch71 opened this issue May 23, 2019 · 2 comments
Closed

Compatibility with Angular 8 #482

Jch71 opened this issue May 23, 2019 · 2 comments
Milestone

Comments

@Jch71
Copy link

Jch71 commented May 23, 2019

Bug Report or Feature Request (mark with an x)
- [ ] Regression (a behavior that used to work and stopped working in a new release)
- [x] Bug report -> please search issues before submitting
- [ ] Feature request
- [ ] Documentation issue or request

Hello,

When I try to use PdfViewer with Angular 8, compiling with Ivy, I get :

Error: Type PdfViewerModule does not have 'ngModuleDef' property.
at getNgModuleDef (VM8703 vendor.js:68747)
at verifySemanticsOfNgModuleDef (VM8703 vendor.js:88543)
at Array.forEach ()
at verifySemanticsOfNgModuleDef (VM8703 vendor.js:88547)
at Function.get (VM8703 vendor.js:88519)
at getInjectorDef (VM8703 vendor.js:65866)
at R3Injector.push../node_modules/@angular/core/ivy_ngcc/fesm5/core.js.R3Injector.processInjectorType (VM8703 vendor.js:80728)
at VM8703 vendor.js:80615
at VM8703 vendor.js:80928
at Array.forEach ()

I guess the package is not ready yet ?

When you build without Ivy, you don't get the error

@VadimDez
Copy link
Owner

Which ng2-pdf-viewer version did you use?

@VadimDez VadimDez added this to the 5.3.1 milestone Jun 1, 2019
VadimDez added a commit that referenced this issue Jun 1, 2019
@VadimDez
Copy link
Owner

VadimDez commented Jun 1, 2019

Fixed in 5.3.1

@VadimDez VadimDez closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants