-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retina display support #46
Comments
Here is a patch (JS version) to use SVG rendering:
This is the best solution. Rendering quality is optimal on all platforms and performance seems to be better too. |
@cbratschi may i have demo ? |
@liangwenzhong We are using the patch as part of an Ionic 2 project. Rendering quality is great on iOS and desktop devices. There was only a problem with a missing font we fixed by updating some PDFs. Unfortunately I cannot provide an online demo because this is a private business app. |
@cbratschi i also use ionic 2 !~ i think we doing the same thing !~but i still have a problem ~~can i use the pinch event ? i wanna zoom the pdf file ~~~~have u did this ? |
@liangwenzhong The SVG based rendering should be fine for zooming without quality loss. What I would need is resize support e.g. from portrait to landscape on mobile devices. Pinching is probably more complicated as this discussion exhibits: I hope the SVG patch will be integrated soon. |
@cbratschi thanks for ur replay so much !~ i have anothre problem . i use ur script below: PdfViewerComponent.prototype['renderPage'] = function(pageNumber) {
} the page's become inverted order . the page2 go to the first page ,the page1 go to the second page . have u resolve this ? :) |
@cbratschi i fix the inverted order problem . :) like: but, i got another problem -.- !~ how to catch the error event ? if an error happened?how can i catch? |
My patch above uses SVG and not a higher resolution bitmap. Performance is therefore better. Please consider adding SVG support too. |
@cbratschi did the change in |
Currently viewport.width and viewport.height are used for the rendering. This does not take retina display into account, such as iOS and macOS devices. The rendered text quality is therefore quite bad.
https://developer.mozilla.org/en/docs/Web/API/Window/devicePixelRatio
Please extend the component to support sub-pixel rendering.
The text was updated successfully, but these errors were encountered: