Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page two way data binding. Do not reset page to 1. #274

Closed
VadimDez opened this issue Feb 10, 2018 · 1 comment
Closed

Page two way data binding. Do not reset page to 1. #274

VadimDez opened this issue Feb 10, 2018 · 1 comment
Assignees
@VadimDez
Labels
enhancement
Milestone
4.1.0

Comments

@VadimDez
Copy link
Owner

Bug Report or Feature Request (mark with an x)
- [ ] Regression (a behaviour that used to work and stopped working in a new release)
- [x] Bug report -> please search issues before submitting
- [x] Feature request
- [ ] Documentation issue or request

As of now if a page is not valid - it will be set to 1. In case you go from the last page to last + 1, it will be changed to the first page rather staying on the last page.
Change the logic to stay on the last page if the page submitted is bigger than the number of pages.
Stay on the first page if the page submitted is less than the page submitted.
@VadimDez VadimDez self-assigned this Feb 10, 2018
@VadimDez VadimDez changed the title Page two way data binding Page two way data binding. Do not reset page to 1. Feb 10, 2018
@VadimDez VadimDez added this to the 4.1.0 milestone Feb 10, 2018
VadimDez added a commit that referenced this issue Feb 10, 2018
@VadimDez
#274 reset page properly when out of bounds
9be555e
VadimDez added a commit that referenced this issue Feb 10, 2018
@VadimDez
Merge pull request #276 from VadimDez/feature/#274
a9eb3ab 
#274 reset page properly when out of bounds
@VadimDez
Copy link
Owner Author

Fixed in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VadimDez VadimDez

Labels
enhancement
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
1 participant
@VadimDez