Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark option #233

Closed
dalbir opened this issue Dec 27, 2017 · 5 comments
Closed

Bookmark option #233

dalbir opened this issue Dec 27, 2017 · 5 comments
Labels
enhancement
Milestone
3.0.8

Comments

@dalbir
Copy link

dalbir commented Dec 27, 2017

Please write code for bookmark option also.
@dalbir
Copy link
Author

dalbir commented Dec 29, 2017

I have found a solution. Can I contribute in your repo for Bookmark

@VadimDez
Copy link
Owner

Sure! Why not?
Just create a pull request, i'll review and merge it.

@dalbir
Copy link
Author

dalbir commented Jan 2, 2018

I have add the code, and created a pull request please review and if fine ok then merge.

VadimDez added a commit that referenced this issue Jan 10, 2018
@VadimDez
#233 made pdfLinkService public
c49c5c3
VadimDez added a commit that referenced this issue Jan 10, 2018
@VadimDez
#233 updated demo: added outline
d6a81ac
@VadimDez VadimDez added this to the 3.0.8 milestone Jan 10, 2018
@VadimDez VadimDez mentioned this issue Jan 10, 2018
Merged
VadimDez added a commit that referenced this issue Jan 10, 2018
@VadimDez
Merge pull request #248 from VadimDez/feature/#233
48b2f39 
Feature/#233
@dalbir
Copy link
Author

dalbir commented Jan 11, 2018

@VadimDez Thanks.

@manojmanic
Copy link

@dalbir of @VadimDez What is the solution for a bookmark option in pdf? let me know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.8
Development

No branches or pull requests
3 participants
@VadimDez @dalbir @manojmanic