Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page number when scrolling on "show-all" mode #223

Closed
anatel opened this issue Dec 12, 2017 · 12 comments
Closed

Update page number when scrolling on "show-all" mode #223

anatel opened this issue Dec 12, 2017 · 12 comments
Milestone

Comments

@anatel
Copy link

anatel commented Dec 12, 2017

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

In "show-all" mode I want to display which page is currently displayed after scrolling to it, meaning I would expect the pageChange event to be emitted when scrolling to a new page.

@anatel anatel changed the title Update page number when scrolling when [show-all]=true Update page number when scrolling on "show-all" mode Dec 12, 2017
@rttmax
Copy link

rttmax commented Jan 8, 2018

+1

1 similar comment
@tamastarjan3
Copy link

+1

@eatmyball
Copy link

Is this issue been fixed?

@TimMeissner
Copy link

+1

@lastSeries
Copy link

lastSeries commented Mar 13, 2018

@VadimDez, is this issue been solved? I hope this issue solved as soon as possible, because my programme need this funciton
Thanks

@WhatzzUp
Copy link

+1

@houssamhammoud
Copy link

@VadimDez is this issue been solved? I hope this issue solved as soon as possible, because my programme need this function?

@adhityan
Copy link

Was this issue resolved? Don't see a page scroll into view event in the documentation.

@jiangyh1024
Copy link

@ColinT

@ColinT
Copy link
Contributor

ColinT commented Jan 25, 2019

Partial solution for 5.2.x: https://github.com/ColinT/ng2-pdf-viewer/tree/issue-223

Two-way binding causes an issue where the page jumps to the top when pageChange emits, since this is the default behavior for @input() page.

To prevent this, use the [page] and (pageChange) bindings separately.

I'll make a PR when this issue is resolved, but I'm not sure how to approach it at this point.

TomLaggna pushed a commit to bormgruppe/ng2-pdf-viewer that referenced this issue Feb 14, 2019
@TomLaggna
Copy link

@ColinT created a PR based on your changes that fixes the remaining problems. #445

VadimDez added a commit to bormgruppe/ng2-pdf-viewer that referenced this issue Oct 9, 2019
VadimDez added a commit that referenced this issue Oct 9, 2019
@VadimDez VadimDez added this to the 5.4.0 milestone Oct 10, 2019
@VadimDez
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests