2.0.0+ doesn't work with ssr

[glemiere]

Hi!

Everything is working fine using webpack and ssr with the version 1.2.7.
However since version 2.0.0 I get the following error when I start my dist/server.js file.

window['pdfjs-dist/build/pdf'] = pdfjs;
^

ReferenceError: window is not defined

[derrick-babb]

Angular Universal also breaks with the same error during server-side rendering, where the window object is not available:
`
window['pdfjs-dist/build/pdf'] = pdfjs;
^

ReferenceError: window is not defined
at Object. (../server.js:172048:1)
at webpack_require (../server.js:26:30)
at Object.defineProperty.value (../server.js:172035:30)
at webpack_require (../server.js:26:30)
at Object.defineProperty.value (../server.js:159976:73)
at webpack_require (../server.js:26:30)
at Object. (../server.js:157478:93)
at webpack_require (../server.js:26:30)
at Object.ROUTES (../server.js:151162:70)
at webpack_require (../server.js:26:30)
`
Notes:

• "ng2-pdf-viewer": "^2.0.2",
• Version 1.2.7 was working up until afternoon of 10/3/17.
• pdf-viewer is used inside of a modal window.

[glemiere]

I found a workaround adding the following to my webpack.server.config.js

    //Temporary fix for ng2-pdf-viewer undefined server-side variables.
    new webpack.DefinePlugin({
      window: [],
      document: {}
    })

However then I have a new problem with Zone :

/dist/server.js:105226
Zone.__load_patch('ZoneAwarePromise', function (global, Zone, api) {
^

I guess this library doesn't support SSR anymore :/

[glemiere]

Any news about SSR support ?

[glemiere]

up

[CanKattwinkel]

I'm currently searching for an PDF viewer that supports Angular Universal. Are there any news on this issue? Would a reproduction repository help?

I don't really need PDF viewer on server side - maybe a simple solution would be to provide a noop-Module like the noopanimationsmodule..

[VadimDez]

Would definitely save me some time if somebody provides a repo where i can reproduce this issue.

[LiverpoolOwen]

@VadimDez any updates on this guys?

[VadimDez]

I'll try to finish this by the end of this week.

[VadimDez]

Fixed in 3.0.2

[glemiere]

Awesome! I'll test soon! ;-)
Thank you for your work!
Could you provide us a few explanation on the way you fixed this ? Could be interesting ;)

[CanKattwinkel]

@glemiere c965b9a

You can either wrap the Window/document statements with if checks or use the document provided via dependency injection (supports querySelector and so on on server side since Angular 5 I think)

[glemiere]

That's nice! Thank you!

[hesampour]

Hi. I have problem in universal with the error Element is not defined. I found that the problem is for this component. Any Idea to fix that?

[arsenlol]

+1 for previous comment:
webpack:///./node_modules/pdfjs-dist/build/pdf.js?:1080
if (typeof Element.prototype.remove !== 'undefined') {

ReferenceError: Element is not defined

[shahbazkhan054]

any update on this?
ReferenceError: Element is not defined

[kkorte]

@hesampour @arsenlol @shahbazkhan054

any update on this?
ReferenceError: Element is not defined

We encountered the same problem, and fixed it in prerender.ts & server.ts by adding the following lines:

win.requestAnimationFrame = () => {};
global['Element'] = {
    prototype: {}
};

[Bizotics-Dev]

@VadimDez can you check this error reproduced again in v5.3.4.