Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker Source #162

Closed
leonardosalles opened this issue Sep 26, 2017 · 3 comments
Closed

Worker Source #162

leonardosalles opened this issue Sep 26, 2017 · 3 comments
Labels
enhancement
Milestone
3.0.4

Comments

@leonardosalles
Copy link

Hi,

I am trying to use the PDFJS.workerSrc with a local file, is it allowed or PDF.js load files from Mozilla?
@VadimDez
Copy link
Owner

For now (since 2.0.0) it's loaded from the CDN

@leonardosalles
Copy link
Author

No problem, I created a local fork of the component and then changed the worker source to a local file, feel free if you want to close this issue or if you want to leave it open as enhancement. Thanks @VadimDez ;)

@VadimDez
Copy link
Owner

VadimDez commented Oct 2, 2017

I think it make sense to add this as a feature, so that everyone can change location of the worker.

bascoder added a commit to bascoder/ng2-pdf-viewer that referenced this issue Dec 27, 2017
@bascoder
Don't overwrite PDFJS.workerSrc if already set
742d203 
If `PDFJS.workerSrc` isn't overwritten when it's set already, then client code is able to set it to the preferred URL.

Related to issue VadimDez#162
@bascoder bascoder mentioned this issue Dec 27, 2017
Merged
VadimDez added a commit that referenced this issue Dec 29, 2017
@VadimDez
Set custom path to worker #162
77510e8
@VadimDez VadimDez added this to the 3.0.4 milestone Dec 29, 2017
VadimDez added a commit that referenced this issue Dec 29, 2017
@VadimDez
#162 added documentation how to set custom worker path
c801159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.4
Development

No branches or pull requests
2 participants
@leonardosalles @VadimDez