Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out of order #111

Closed
zackfly opened this issue Jul 26, 2017 · 1 comment
Closed

out of order #111

zackfly opened this issue Jul 26, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@zackfly
Copy link

zackfly commented Jul 26, 2017

when i try to pass a large file ,i found a bug .
For example , my pdf hava 120 pages and in the end No.100 appear at the end . No ,111 appear in the middle
this is the file http://vdisk.weibo.com/s/cT6E1uU_bsW73
u can upload in https://vadimdez.github.io/ng2-pdf-viewer/

@zackfly
Copy link
Author

zackfly commented Jul 26, 2017

i think the answer is
PdfViewerComponent.prototype.renderMultiplePages = function () {
var container = this.element.nativeElement.querySelector('div');
this.removeAllChildNodes(container);
for (var page = 1; page <= this._pdf.numPages; page++) {
this.renderPage(page);
}
For renderPage is asynchronous,so order wouldn't be guaranteed

and ,also when large pdf is passed. some of them maybe can not be displayed.

@VadimDez VadimDez added the bug label Jul 26, 2017
@VadimDez VadimDez self-assigned this Jul 30, 2017
@VadimDez VadimDez added this to the 1.1.1 milestone Jul 30, 2017
VadimDez added a commit that referenced this issue Jul 31, 2017
Fixes #111, load pages synchronously to keep order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants