Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant view permission #88

Merged
merged 9 commits into from
May 14, 2024
Merged

feat: grant view permission #88

merged 9 commits into from
May 14, 2024

Conversation

thashimoto1998
Copy link
Contributor

No description provided.

@thashimoto1998 thashimoto1998 changed the title feat: grantViewPermisssion feat: grant view permission May 1, 2024
Copy link

@wakoto3 wakoto3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seki-seki seki-seki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

口頭で話した通り、

  1. 先祖がgrantされていればgrantされているものとみなす
  2. 先祖がgrantされていればgrantする必要がないのでエラーとする
    仕様をいれてください

Copy link
Contributor

@seki-seki seki-seki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thashimoto1998 thashimoto1998 merged commit 9b8bb2a into master May 14, 2024
1 check passed
@thashimoto1998 thashimoto1998 deleted the feat/grant branch May 14, 2024 10:52
thashimoto1998 added a commit that referenced this pull request Sep 12, 2024
feat: grant view permission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants