Add new logo

[atraest]

• Added a new logo to the project.
• Size was respected and maintained in every directory which the logo is found.
  • Some icons had asymmetric and inconsistent positions, which was fixed. But some required small positional adjustments in order to not conflict with the central icons on src/resources/win32 and still preserve the original sizes of each icon element.

[atraest]

Hey @stripedpajamas Just letting you know I recently changed my account name and link (I'm Cristiano Vitorino, author of this PR and designer of the new logo). For current and future credit you can just use "Atra", all my links are updated.

[stripedpajamas]

Thanks @estatra !! Sorry (again) for the delay. I'm just going to pull down your changes and build so I can spot-check the finished product. Will merge when I've confirmed!

[atraest]

Thanks @estatra !! Sorry (again) for the delay. I'm just going to pull down your changes and build so I can spot-check the finished product. Will merge when I've confirmed!

Awesome! Let me know if anything needs change/improvement.

[stripedpajamas]

I downloaded the built DMG (built into my fork https://github.com/stripedpajamas/vscodium/releases/tag/1.46.1):

• I found the DMG window to have a grainy icon
  
• I found the taskbar icon to also be grainy (the Mac ZIP file has the same issue, so not DMG-specific):
  

[atraest]

@stripedpajamas Weird. I mirrored the original logos exactly, dimension wise. To me it seams like both the original and my version are too small, the .icns file in this case, which is 32x32 pixels.

• Can you confirm that this doesn't happen with the original? Since the original is the same size, I'm not sure that if I just make it larger will solve the problem.
• Where does the DMG dialog box and taskbar icon gets the logo from? What are the paths that the code uses?
• Do you have any specific script or code block that takes an SVG as input and output that .icns file? That could be the problem in the CI/CD pipeline? Since my version would be "baked" already. But that doesn't explain the original 32x32 .icns either.

[stripedpajamas]

I'm no expert on icon files, but when I get info on the same file from VSCodium main branch (src/resources/darwin/code.icns), my Mac is showing dimensions 1024x1024. Isn't it a thing that different dimensions can be embedded into a single icon file? Again, I'm no expert.

[atraest]

I'm no expert on icon files, but when I get info on the same file from VSCodium main branch (src/resources/darwin/code.icns), my Mac is showing dimensions 1024x1024. Isn't it a thing that different dimensions can be embedded into a single icon file? Again, I'm no expert.

Neither am I in .icns or .ico files. My apologies. I noticed that this is the case for the .ico files as well. But since I only used a simple conversion for the .icns and never opened it, I didn't noticed the embedded versions.

[Atn-D]

The .icns do not contain a single image but a collection.

It allows among other things to have a design that adapts to the scale.

(I hope I'm not off topic)

[atraest]

The .icns do not contain a single image but a collection.
It allows among other things to have a design that adapts to the scale.
(I hope I'm not off topic)

Sure, I got that.

---

I've found some neat tools on Linux that will make the endeavor faster. Also, there are more icons for macOS that needs fixing, gonna do that. I started working on it and will continue tomorrow, it's really late and I'm going to bed soon.

My apologies @stripedpajamas The embedded structure totally flew over my head. Specially because they don't follow a pattern as I looked further into them, I need to verify batch by batch now to see the size range plus the misaligned icons from the original.

Good news is once they're done and ready, they will be even better and more accurate than before.

---

@stripedpajamas I've found new problems. For example. In the official VSCode repo, on the Windows icon folder, the original code.ico file has 3 images embedded, but the VSCodium repo has 4. The c.ico on VSCode repo has 9 files, on VSCodium, only 6. These represent different sizes. There are discrepancies everywhere between the two repos, icon wise.

Which repo icon structure should I follow? The original VSCode one or VSCodium's?

[stripedpajamas]

@estatra no worries at all! Thank you so much for all the time and effort you've already put in. In regard to icon structure: follow whatever original VSCode repo has. Our icons were committed 2 years ago and have not changed much since (and people find icons we missed all the time).

[atraest]

@stripedpajamas No problem. Since VSCode repo doesn't have internal releases, I'll use the .zip from the latest commit, which is #100941 from 3 hours ago as reference.

I'll try to get this done as soon as I can, but please allow me a few days to finish. I'll push the changes to this PR as soon as they're ready for you to test.

[atraest]

@stripedpajamas Done! Commit ready for review.

Changelog

• Remade ICNS files.
• Remade ICO files.
• Upstream had an icon with wrong/bad alignment. Fixed.
• Added missing icons. Upstream used as source.

[cristianbote]

I am really sorry that I'm gonna be off-topic a bit, but y'all rock! 💯 🎉 Been using vscodium for more than 3-4 weeks and everything is bliss! I can't wait to get the new icon! 😃 Looks sooooooo nice!

Keep up the good work!

[stripedpajamas]

Alright... looking good. I tested on Windows and most everything looked proper, except I did notice the "titlebar icon" had the old Code - OSS icon:

The other icon here (the "Welcome" one)... I think @Oekn5w found where the path to that icon lives in their PR (#440), but that PR uses the old codium icon. @estatra if you have some time, can you include their changes in this PR with the new icon?

As to the Windows titlebar icon, I'm not sure where it lives in the vscode repo, but it might incidentally be one of the 3 files changes in #440.

[Oekn5w]

@estatra I think the Windows icon also uses the one whose path is changed in my PR #440 . I've asked @stripedpajamas to confirm as I lack a Windows development environment

[atraest]

@stripedpajamas @Oekn5w Done. Please check if this works and if everything is in order. Some directories might be redundant but I'm not sure, so I didn't remove anything, just added the missing icons, hopefully on the right place with help from Oekn5w's PR.

[stripedpajamas]

Awesome; building it now for testing.

[stripedpajamas]

Windows looks good:

[stripedpajamas]

Mac OS looks good too. I will go ahead and merge this! Thanks for the amazing work (and patience) @estatra !

We should see the new icons in next MS release.

[atraest]

Mac OS looks good too. I will go ahead and merge this! Thanks for the amazing work (and patience) @estatra !

We should see the new icons in next MS release.

Awesome! My pleasure! It was a fun ride : )

[geekley]

@stripedpajamas

Alright... looking good. I tested on Windows and most everything looked proper, except I did notice the "titlebar icon" had the old Code - OSS icon:

After the logo reversion, I'm getting the Code-OSS icon in Linux snap as well (Kubuntu, KDE Plasma), instead of a coral icon.

[Oekn5w]

@geekley see #440, these changes where included in here, I've reopened the PR to fix this